build,tools: use mkcodecache to add code cache to the binaries#27161
Merged
refack merged 3 commits intonodejs:masterfrom Apr 16, 2019
Merged
build,tools: use mkcodecache to add code cache to the binaries#27161refack merged 3 commits intonodejs:masterfrom
refack merged 3 commits intonodejs:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
lib / src
2 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
Current change-set works on all platforms (except the RPIs), test failures are most probably flakes. Reviews are welcome. |
refack
added
build
This comment has been minimized.
This comment has been minimized.
joyeecheung
approved these changes
Apr 12, 2019
Member
joyeecheung
left a comment
joyeecheung
left a comment
There was a problem hiding this comment.
Thanks for working on this!
joyeecheung
reviewed
Apr 13, 2019
refack
force-pushed
the
new-mkcodecache
branch
2 times, most recently
from
501a151 to
1d2feb7
Compare
This comment has been minimized.
This comment has been minimized.
This was referenced Apr 17, 2019
This was referenced Apr 23, 2019
This was referenced Jan 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #27135
and #27108
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes